Terraform always reports firewall changes are needed

[dghubble]

Bug

Environment

Platform: Digital Ocean
OS: Container Linux
Terraform: v0.10.1-dev
Ref: f044113

Actual Behavior

Terraform always reports that firewall changes need to be made when running terraform plan after successful cluster creation, even though the correct firewall rules exist. This is an issue with the upstream provider plugin: https://github.com/terraform-providers/terraform-provider-digitalocean/issues/30

$ terraform plan
  ~ module.mycluster.digitalocean_firewall.rules
      inbound_rule.3.port_range:  "0" => "all"
      inbound_rule.3.protocol:    "tcp" => "udp"
      inbound_rule.4.port_range:  "0" => "all"
      inbound_rule.4.protocol:    "udp" => "tcp"
      outbound_rule.0.port_range: "0" => ""
      outbound_rule.0.protocol:   "udp" => "icmp"
      outbound_rule.1.port_range: "0" => "all"
      outbound_rule.1.protocol:   "icmp" => "udp"
      outbound_rule.2.port_range: "0" => "all"

While annoying, its better to keep the newly added firewall rules and wait for the provider to improve than to revert the cluster firewall rules. Users can terraform apply and it won't harm the rules.