Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx Ingress Controller: no need for default-backend #398

Closed
JordanP opened this issue Feb 13, 2019 · 1 comment
Closed

Nginx Ingress Controller: no need for default-backend #398

JordanP opened this issue Feb 13, 2019 · 1 comment

Comments

@JordanP
Copy link
Contributor

JordanP commented Feb 13, 2019

Hi,
Since Nginx Ingress controller v0.21 and this commit [1], it's not required to have a default backend service anymore. I suggest you remove these lines [2] and also the default-backend folder. It will simplify the deployment a bit with one less piece of software.

[1] kubernetes/ingress-nginx@0bb5934#diff-b7d944663319ec93108dd9eb66df1d9d
[2] https://github.com/poseidon/typhoon/blob/master/addons/nginx-ingress/google-cloud/deployment.yaml#L30

@dghubble
Copy link
Member

Nice 👍 And most important, Nginx is configured to serve the 404 on its own so the behavior remains the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants