AWS NLB - controllers #136
Conversation
| } | ||
| } | ||
|
|
||
| resource "aws_lb_listener" "apiserver-443" { |
There was a problem hiding this comment.
Resource naming convention would be apiserver-https if you look at other places in the project.
There was a problem hiding this comment.
I'll provide a change soon'ish. probably tomorrow morning.
| resource "aws_lb" "apiserver" { | ||
| name = "${var.cluster_name}-apiserver" | ||
| load_balancer_type = "network" | ||
| subnets = ["${aws_subnet.public.*.id}"] |
There was a problem hiding this comment.
You've removed the security group
There was a problem hiding this comment.
Disregard, I see network load balancer doesn't allow it.
|
|
||
| # Kubelet HTTP health check | ||
| health_check { | ||
| target = "SSL:443" | ||
| protocol = "TCP" |
There was a problem hiding this comment.
Yes. Required to get the healthcheck working with nlb's.
| } | ||
|
|
||
| resource "aws_lb_target_group_attachment" "apiserver" { |
There was a problem hiding this comment.
"apiservers" or better yet "controllers" would match the established patterns
There was a problem hiding this comment.
I'll provide a fix soon changing it to controllers.
|
In answer to your question:
My current setup is. |
* Renames lb. Changes suffix from 443 to https. * Renames target-group-attachment to "controllers".
|
The new minimum version for the terraform-provider-aws plugin is 1.7.0, as established in #141. You won't have to worry about it after all, since that's already made its way to master. |
|
Squashed and merged with a few minor tweaks in ceb5555. Thanks! |
Controller load balancer set to an AWS NLB
Testing
deployed/destroyed/applied all addons.
ref: #130