Fix overly strict firewall for GCP "worker pools" #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dghubble
changed the title
dghubble
force-pushed
the
fix-gcp-worker-pool-issue
branch
2 times, most recently
from
8ef68ee to
34d2b7b
Compare
* Fix issue where worker firewall rules didn't apply to additional workers attached to a GCP cluster using the new "worker pools" feature (unreleased, #148). Solves host connection timeouts and pods not being scheduled to attached worker pools. * Add `name` field to GCP internal worker module to represent the unique name of of the worker pool * Use `cluster_name` field of GCP internal worker module for passing the name of the cluster to which workers should be attached
dghubble
force-pushed
the
fix-gcp-worker-pool-issue
branch
from
34d2b7b to
45b556c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namefield to GCP internal worker module to represent the unique name of the worker poolcluster_namefield of GCP internal worker module for passing the name of the cluster to which workers should be attachedNotes
No security impact. The worker pool firewalls default to disallow. This issue is about lacking whitelisting rules (i.e. they're too strict) that should be present.
No breakages. The new required
namefield is not covered in the changelog because through the v1.9.3 release, the Terraform "worker" submodule was considered internal. No docs suggested it could be used directly and there were a number of issues with attempting to do so.Testing
Evaluated this after running into issues with workloads that required scheduling on the attached "worker pool". Verified cross-worker-pool network pod-to-pod connectivity and pods scheduled across pools.