Allow for using Flatcar Linux instead of Container Linux #209

dongsupark · 2018-05-08T14:55:48Z

Make the bare-metal provider work based on not only Container Linux but also Flatcar Linux. To use Flatcar Linux, user needs to set a config variable os_channel to one of the following variables: flatcar-stable, flatcar-beta, flatcar-alpha.

Also create a new profile fl for Flatcar Linux, and rename a corresponding config variable container_linux_version to os_version.

dghubble · 2018-05-09T02:56:15Z

Thanks! I've been thinking about some different ways of allowing Flatcar Linux (and potentially other Container Linux derivatives) around v1.11.x timeframe. Bare-metal is certainly the biggest commitment, so I'd like to explore allowing it on clouds first ideally.

For bare-metal, I'm thinking neither container_linux nor flatcar_linux should actually appear in variable names. Instead of boolean type conditionals, I'd like to see if we can make this more like specifying a channel or flavor once, for better usability. I'd like to borrow the GCP-like semantics of image = "coreos-stable", so I'd aim for something more like channel = "coreos-stable" and channel = "flatcar-stable". And then have separate install profiles, its odd to look through a Matchbox store and see Flatcar inside a CL profile.

Will Flatcar have the same notion of alpha, beta, stable? Interesting the user was kept as "core", but kernel args were renamed.

dongsupark · 2018-05-09T09:01:55Z

@dghubble Thanks.
In the beginning I have thought about creating a different profile fl for Flatcar, but I didn't want to do that because of the size of PR. But if you think that's the way to go, I can create a different profile.

Setting a flavor (flatcar / coreos) in the channel name sounds like a good idea. I'll update my PR just like you do in #211.

Flatcar has exactly the same channel names, stable, beta, and alpha. Though the default user name is still core for now.

Make the bare-metal provider work based on not only Container Linux but also [Flatcar Linux](https://flatcar-linux.org). To use Flatcar Linux, user needs to set a config variable `os_channel` to one of the following variables: `flatcar-stable`, `flatcar-beta`, `flatcar-alpha`. Also create a new profile `fl` for Flatcar Linux, and rename a corresponding config variable `container_linux_version` to `os_version`.

dongsupark · 2018-05-09T11:15:42Z

@dghubble Updated, and force-pushed. Is it ok for you?

dghubble · 2018-05-10T08:27:02Z

bare-metal/container-linux/kubernetes/fl/controller.yaml.tmpl

@@ -0,0 +1,171 @@
+---


I'd like to keep the Ignition for Container Linux derivatives unified. If I allowed Flatcar to drift, I might have to allow future derivatives and I'd like to keep everything aligned for a while

dghubble · 2018-05-10T08:28:54Z

bare-metal/container-linux/kubernetes/fl/controller.yaml.tmpl

+        ExecStartPre=/bin/mkdir -p /var/lib/kubelet/volumeplugins
+        ExecStartPre=/usr/bin/bash -c "grep 'certificate-authority-data' /etc/kubernetes/kubeconfig | awk '{print $2}' | base64 -d > /etc/kubernetes/ca.crt"
+        ExecStartPre=-/usr/bin/rkt rm --uuid-file=/var/cache/kubelet-pod.uuid
+        ExecStart=/usr/lib/flatcar/kubelet-wrapper \


You have /usr/lib/coreos/kubelet-wrapper in your image, let's keep using that for now.

dghubble · 2018-05-10T08:30:02Z

docs/cl/bare-metal.md

@@ -186,8 +186,8 @@ module "bare-metal-mercury" {
  # bare-metal
  cluster_name            = "mercury"
  matchbox_http_endpoint  = "http://matchbox.example.com"
-  container_linux_channel = "stable"
-  container_linux_version = "1632.3.0"
+  os_channel              = "stable"


coreos-stable

dghubble · 2018-05-10T08:33:08Z

bare-metal/container-linux/kubernetes/profiles.tf

@@ -1,18 +1,39 @@
+locals {
+  flavor  = "${element(split("-", var.os_channel), 0)}"


One of the nice properties of #211 is that if a user inputs a value like stable (instead of coreos-stable), the Terraform error strongly hints at the problem showing the AMI data source and indicating that no matching images were found.

I wouldn't do any contortion to make something similar here, but worth considering.

dghubble · 2018-05-10T08:38:07Z

bare-metal/container-linux/kubernetes/profiles.tf

+  flavor  = "${element(split("-", var.os_channel), 0)}"
+  channel = "${element(split("-", var.os_channel), 1)}"
+
+  profile      = "${local.flavor == "flatcar" ? "fl" : "cl"}"


Sorry. I was unclear in my review. By separate profile, I was referring to separate Matchbox Profiles. A Matchbox profile defines the initrd, kernel, args, etc. that should be used by matched machines. I was proposing instead of using variables throughout the "container-linux-install" "matchbox_profile", I'd consider defining a separate "flatcar-linux-install" profile.

Wasn't proposing making separate directories for cl and fl

dghubble · 2018-05-10T08:39:37Z

bare-metal/container-linux/kubernetes/profiles.tf

-    container_linux_channel = "${var.container_linux_channel}"
-    container_linux_version = "${var.container_linux_version}"
+    os_channel              = "${local.channel}"
+    os_version              = "${var.os_version}"
    ignition_endpoint       = "${format("%s/ignition", var.matchbox_http_endpoint)}"
    install_disk            = "${var.install_disk}"
    container_linux_oem     = "${var.container_linux_oem}"


Vaguely unrelated to your PR, but this will probably be dropped at some point. So don't worry about the oem setting.

dghubble · 2018-05-10T08:41:35Z

bare-metal/container-linux/kubernetes/profiles.tf

@@ -40,21 +61,21 @@ data "template_file" "container-linux-install-configs" {
 }

 // Container Linux Install profile (from matchbox /assets cache)
-// Note: Admin must have downloaded container_linux_version into matchbox assets.
+// Note: Admin must have downloaded os_version into matchbox assets.
 resource "matchbox_profile" "cached-container-linux-install" {


You can skip making a flatcar-cached-install profile for now. Without the standard Matchbox setup having an analog of https://github.com/coreos/matchbox/blob/master/scripts/get-coreos, I don't think users will prepare those assets correctly and it'll lead to issues being filed. Let's consider it in a followup.

dghubble · 2018-05-10T08:43:06Z

bare-metal/container-linux/kubernetes/fl/flatcar-linux-install.yaml.tmpl

+        inline: |
+          #!/bin/bash -ex
+          curl --retry 10 "${ignition_endpoint}?{{.request.raw_query}}&os=installed" -o ignition.json
+          flatcar-install \


Hmm, I guess template in coreos vs flatcar in the common container-linux-install.yaml.tmpl (still need to think about renaming the file with all the RH news and shifting names). If the intention is to slowly convert all instances of core to flatcar within the OS, that feels like its going to be painful.

aknuds1 · 2018-05-11T07:56:36Z

I'm also interested in Flatcar since I learnt of their fork of Container Linux in the wake of the Red Hat takeover :) I might want to switch my clusters over to it (from CL), but haven't investigated yet.

dghubble · 2018-05-15T06:45:44Z

I'm happy to take this on myself. I'd like to get this running myself and I recognize I'm pretty particular about how its implemented, having written Matchbox too. This PR does provide me excellent context for the handful of naming changes and URLs for Flatcar Linux.

dongsupark · 2018-05-15T08:59:38Z

@dghubble Sorry for late reply. I have been on holiday.
I was going to address your review in this week. But if you want to take over this PR, I'd appreciate. Please go ahead. 👍

dongsupark · 2018-05-17T15:50:24Z

A new PR #220 will replace this PR. So I'll close this one.

* Support bare-metal cached_install=true mode with Flatcar Linux where assets are fetched from the Matchbox assets cache instead of from the upstream Flatcar download server * Skipped in original Flatcar support to keep it simple #209

* Support bare-metal cached_install=true mode with Flatcar Linux where assets are fetched from the Matchbox assets cache instead of from the upstream Flatcar download server * Skipped in original Flatcar support to keep it simple poseidon/typhoon#209

* Support bare-metal cached_install=true mode with Flatcar Linux where assets are fetched from the Matchbox assets cache instead of from the upstream Flatcar download server * Skipped in original Flatcar support to keep it simple poseidon#209

dghubble mentioned this pull request May 9, 2018

Allow Flatcar Linux os_channel on AWS #211

Merged

dongsupark force-pushed the dongsu/flatcar-switch branch from 2d563f0 to 12c597e Compare May 9, 2018 11:11

dghubble reviewed May 10, 2018

View reviewed changes

dghubble added kind/feature platform/bare-metal labels May 10, 2018

dghubble mentioned this pull request May 17, 2018

Allow Flatcar Linux os_channel on bare-metal #220

Merged

dongsupark closed this May 17, 2018

dongsupark deleted the dongsu/flatcar-switch branch May 17, 2018 15:50

dghubble mentioned this pull request Oct 16, 2018

bare-metal: support cached install for Flatcar #315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow for using Flatcar Linux instead of Container Linux #209

Allow for using Flatcar Linux instead of Container Linux #209

dongsupark commented May 8, 2018 •

edited

Loading

dghubble commented May 9, 2018

dongsupark commented May 9, 2018 •

edited

Loading

dongsupark commented May 9, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

dghubble May 10, 2018

aknuds1 commented May 11, 2018 •

edited

Loading

dghubble commented May 15, 2018

dongsupark commented May 15, 2018

dongsupark commented May 17, 2018

		@@ -1,18 +1,39 @@
		locals {
		flavor = "${element(split("-", var.os_channel), 0)}"

Allow for using Flatcar Linux instead of Container Linux #209

Allow for using Flatcar Linux instead of Container Linux #209

Conversation

dongsupark commented May 8, 2018 • edited Loading

dghubble commented May 9, 2018

dongsupark commented May 9, 2018 • edited Loading

dongsupark commented May 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aknuds1 commented May 11, 2018 • edited Loading

dghubble commented May 15, 2018

dongsupark commented May 15, 2018

dongsupark commented May 17, 2018

dongsupark commented May 8, 2018 •

edited

Loading

dongsupark commented May 9, 2018 •

edited

Loading

aknuds1 commented May 11, 2018 •

edited

Loading