Add small CPU resource requests to static pods #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dghubble
force-pushed
the
control-plane-cpu-request
branch
from
b3e8826 to
2732923
Compare
* Set small CPU requests on static pods kube-apiserver, kube-controller-manager, and kube-scheduler to align with upstream tooling and for edge cases * Effectively, a practical case for these requests hasn't been observed. However, a small static pod CPU request may offer a slight benefit if a controller became overloaded and the below mechanisms were insufficient Existing safeguards: * Control plane nodes are tainted to isolate them from ordinary workloads. Even dense workloads can only compress CPU resources on worker nodes. * Control plane static pods use the highest priority class, so contention favors control plane pods (over say node-exporter) and CPU is compressible too. See: poseidon/terraform-render-bootstrap#161
dghubble
force-pushed
the
control-plane-cpu-request
branch
from
2732923 to
0e4ee5e
Compare
dghubble
added a commit
that referenced
this pull request
Nov 22, 2019
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating #589
dghubble-robot
pushed a commit
to poseidon/terraform-onprem-kubernetes
that referenced
this pull request
Nov 22, 2019
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon/typhoon#589
dghubble-robot
pushed a commit
to poseidon/terraform-digitalocean-kubernetes
that referenced
this pull request
Nov 22, 2019
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon/typhoon#589
dghubble-robot
pushed a commit
to poseidon/terraform-aws-kubernetes
that referenced
this pull request
Nov 22, 2019
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon/typhoon#589
dghubble-robot
pushed a commit
to poseidon/terraform-google-kubernetes
that referenced
this pull request
Nov 22, 2019
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon/typhoon#589
dghubble-robot
pushed a commit
to poseidon/terraform-azure-kubernetes
that referenced
this pull request
May 25, 2020
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon/typhoon#589
Snaipe
pushed a commit
to aristanetworks/monsoon
that referenced
this pull request
Apr 13, 2023
* Fix deletion of bootstrap module pinned SHA, which was introduced recently through an automation mistake creating poseidon#589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing safeguards:
See: poseidon/terraform-render-bootstrap#161