Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set kubeconfig and asset_dist as sensitive #885

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

dghubble
Copy link
Member

  • Mark kubeconfig and asset_dist as sensitive to prevent the Terraform CLI displaying these values, esp. for CI systems
  • In particular, external tools or tfvars style uses (not recommended) reportedly display all outputs and are improved by setting sensitive
  • For Terraform v0.14, outputs referencing sensitive fields must also be annotated as sensitive

Closes #884

* Mark `kubeconfig` and `asset_dist` as `sensitive` to
prevent the Terraform CLI displaying these values, esp.
for CI systems
* In particular, external tools or tfvars style uses (not
recommended) reportedly display all outputs and are improved
by setting sensitive
* For Terraform v0.14, outputs referencing sensitive fields
must also be annotated as sensitive

Closes #884
@dghubble dghubble merged commit c0347ca into master Nov 23, 2020
@dghubble dghubble deleted the explicit-sensitive branch November 25, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking assets_dist as a sensitive output in typhoon as well
1 participant