Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to repos, to increase harmony for renv users #4255

Closed
juliasilge opened this issue Aug 6, 2024 · 2 comments
Closed

Add attribute to repos, to increase harmony for renv users #4255

juliasilge opened this issue Aug 6, 2024 · 2 comments
Assignees
Labels

Comments

@juliasilge
Copy link
Contributor

Related to:

In Positron, we do in fact set repos to "https://cran.rstudio.com/" the same as RStudio:

https://github.com/posit-dev/ark/blob/9387883055176bb0493b9893cd392f53a1bda0ed/crates/ark/src/modules/positron/options.R#L30-L45

But RStudio also adds an attribute:

getOption("repos")
#>                        CRAN 
#> "https://cran.rstudio.com/" 
#> attr(,"RStudio")
#> [1] TRUE

Created on 2024-08-06 with reprex v2.1.1

Let's add an attribute of "Positron" so that renv can pick it up in its logic for deciding whether to use PPM.

@juliasilge
Copy link
Contributor Author

Once we bump ark, we can verify that we now see an attribute on this option:

getOption("repos")
#>                        CRAN 
#> "https://cran.rstudio.com/" 
#> attr(,"IDE")
#> [1] TRUE

Created on 2024-09-04 with reprex v2.1.1

I will also need to update at rstudio/renv#1963 once this is in a publicly available release build.

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.09.0-11
OS Version          : OSX

Test scenario(s)

getOption("repos")

CRAN
"https://cloud.r-project.org"

Link(s) to TestRail test cases run or created:
N/A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants