Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition and Flameout Engine Event Controllers trigger incorrectly in MultiModeEngines #126

Closed
HB-Stratos opened this issue Mar 26, 2023 · 1 comment
Labels
bug Something isn't working next release Done, coming in next release

Comments

@HB-Stratos
Copy link

Adding an Ignition and a Flameout event controller to a multi mode engine like e.g. a panther leads to some bad behavior.
In dry mode it works correctly, ignition and flameout trigger with engine on or off.
However, flameout also triggers when the engine switches from dry to wet mode, and ignition triggers when switching back to dry mode. It is also not possible to give the controller an engine ID to listen to, so it wrongly responds to dry mode even for FX that target the wet mode.
A better implementation of this might be to add a engineID parameter to the event controller. Additionally it would be helpful to have a mode switch or rather a mode enable and a mode disable module. Only the first change of being able to target a specific engineID with the event controller would already allow FX like e.g. afterburner ignition or flameout, which is currently not possible.

@ChrisAdderley ChrisAdderley added next release Done, coming in next release bug Something isn't working labels Sep 21, 2024
@ChrisAdderley
Copy link
Collaborator

Released in 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next release Done, coming in next release
Projects
None yet
Development

No branches or pull requests

2 participants