Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(collapseWhitespace): handle textNode when comment is preserved #184

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix(collapseWhitespace): handle textNode when comment is preserved #184

merged 1 commit into from
Apr 6, 2022

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Apr 6, 2022

Fix a very rare edge case that collapseWhitespace module wrongly trim a whitespace when removeComments module is disabled. This PR makes sure the whitespace will not be trimmed when prevNode or nextNode is text nodes (or comments).

@netlify
Copy link

netlify bot commented Apr 6, 2022 •
edited

‼️ Deploy request for htmlnano rejected.

Name Link
🔨 Latest commit 7a3d8ad

@maltsev maltsev merged commit ead5613 into posthtml:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SukkaW @maltsev