Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safe preset #50

Closed
DeMoorJasper opened this issue Apr 27, 2018 · 3 comments
Closed

Add a safe preset #50

DeMoorJasper opened this issue Apr 27, 2018 · 3 comments

Comments

@DeMoorJasper
Copy link
Contributor

DeMoorJasper commented Apr 27, 2018

It would be nice to have an option called safe that sets the optimal preset for minifying html safely, without having to thinker around untill you get a universal htmlnano config that works safe for everyone.

This idea came from trying to optimise the universal config for parcel, as we from time to time get a bug report with an unsafe transform.

If there is intrest for this feature but no available time, I'd love to implement this

@maltsev
Copy link
Member

maltsev commented Apr 28, 2018

Hi @DeMoorJasper,

I'm definitely interested in making htmlnano minifications safe by default for all types of HTML. Actually, I think we don't need a preset for that. All modules should minify code without breaking it by default. That was also my intention initially. And if someone wants to minify their code even more they could enable some hard-minifying options (in such case a preset you suggested would come in handy).

So I think we should solve that issue by changing the default modules config. Your help would be really appreciated, as, unfortunately, I don't have time right now for that. How does that sound to you?

@DeMoorJasper
Copy link
Contributor Author

Awesome! I'll do a PR in a bit

@maltsev
Copy link
Member

maltsev commented Apr 29, 2018

@DeMoorJasper thanks for making the default minification options even safer! I published new version 0.1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants