Add a more aggressive whitespace removal option to the collapseWhitespace plugin #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat removes incidental spacing such as tabs and newlines. Useful when there is a lot of structured markup and not much actual text. NOTE: a small behavioural change was introduced in order to match the documentation - single whitespace (newlines/tabs) are now replaced by a single space.
maltsev
reviewed
Aug 16, 2020
| if (collapseType !== 'all') { | ||
| collapseType = 'conservative'; | ||
| } | ||
| collapseType = (collapseType && validOptions.some(o=>o === collapseType)) ? collapseType : 'conservative'; |
There was a problem hiding this comment.
This could be simplified to
Suggested change
| collapseType = (collapseType && validOptions.some(o=>o === collapseType)) ? collapseType : 'conservative'; | |
| collapseType = validOptions.includes(collapseType) ? collapseType : 'conservative'; |
There was a problem hiding this comment.
Oh boy, I didn't know about the .includes method, I learnt something awesome today, thanks!
Although, I see you already merged the PR... so do you want a new PR for this simplification or do you want to just let it go?
There was a problem hiding this comment.
so do you want a new PR for this simplification or do you want to just let it go?
It's up to you :-)
There was a problem hiding this comment.
Always better to keep things tidy imho : #91
|
Thanks for your PR and sorry for the delay with getting back to you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose an addition/change to the 'collapseWhitespace' plugin to more aggressively remove semantically redundant whitespace.
I saw, looking at the output of my minified code, lots of spaces being introduced where none existed in my input. These turned out to be a translation of the indentation/newlines into a single space. Since almost all of the markup was structural none of those spaces were adding anything of value.
Therefore I suggest that a new 'aggressive' mode be introduced that removes structural/incidental whitespace such as this. Actual space characters can be collapsed but should not be removed as they are essential between inline tags (e.g. title</b> <i>part).
This pull request is a first attempt at implementing such behaviour.
Is this something you would consider for inclusion in the main htmlnano project?
NOTE: a small behavioural change was introduced to match the documentation - a single space now replaces individual newlines/tabs. I don't think this should have any impact on downstream consumers since html generally allows whitespace to be collapsed/replaced.