Feat: bring up minifyUrls #98
Conversation
| @@ -27,4 +27,5 @@ export default { | |||
| removeRedundantAttributes: false, | |||
| removeComments: 'safe', | |||
| sortAttributesWithLists: true, | |||
| minifyUrls: false, | |||
There was a problem hiding this comment.
minifyUrls should be considered as dangerous and shouldn't be enabled by default.
The option is not added in the max preset either since it requires the user's configuration.
|
@SukkaW thanks a lot for these PRs! I highly appreciate your contributions to htmlnano! |
Thanks! Though, is there a reason to not include the docs updates in the same PR? |
Sure. Thanks! Then I'll wait with releasing a new version until that PR is merged as well. |
I'm not sure if my implementation will be accepted. There might also be a better implementation for the same feature, so I decide to split the document into another PR. I can include both implementation and the document change in one PR if you wish. |
Fair enough. Let's keep it that way then. |
The PR closes #10.
The document will be updated in another PR after this one is merged.
P.S.
I'm also refactoring
Object.keysintoObject.entrieswhich will land in another PR. That PR should be included in the new release as well.