Output all identifiers and mac address when scanning with atvscript #2282
Conversation
maxileith
force-pushed
the
atvscriptBuff
branch
from
25b8762
to
61b2ac8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
- Coverage 88.95% 88.80% -0.15%
==========================================
Files 168 168
Lines 11370 11370
==========================================
- Hits 10114 10097 -17
- Misses 1256 1273 +17 ☔ View full report in Codecov by Sentry. |
maxileith
force-pushed
the
atvscriptBuff
branch
3 times, most recently
from
fb4887b
to
c8106d3
Compare
maxileith
force-pushed
the
atvscriptBuff
branch
5 times, most recently
from
3708120
to
be19f3e
Compare
maxileith
force-pushed
the
atvscriptBuff
branch
from
be19f3e
to
a3a4c65
Compare
|
I have updated the pull request to include the MAC-Address in the device infos since I noticed that this is available on the atv object anyways |
maxileith
changed the title
|
Hi @postlund , Can you do a ruff estimation on when you will have the time to look at the PR? I don't want to stress, I am just curious and would like to evaluate wether I will wait for the PR or do a workaround 😬 |
|
@maxileith Sorry about the delay, I will try to get around doing that this week! |
|
Sorry for not getting back sooner on this, but it looks good to me! 👍 I'll see if there's anything else to include, otherwise I can make a minor release soon with this change. |
|
@postlund don't worry about the late response. We all have private lifes besides our passion for FOSS 😉 |
adding the new mac attribute introduced in postlund/pyatv#2282 to the device.
adding the new all_identifiers attribute introduced in postlund/pyatv#2282 to the device as allIDs.
adding the new mac attribute introduced in postlund/pyatv#2282 to the device.
# [7.2.0](v7.1.0...v7.2.0) (2023-12-26) ### Features * **core:** add allIDs attribute to device ([02a9c05](02a9c05)), closes [postlund/pyatv#2282](postlund/pyatv#2282) * **core:** add mac attribute to device ([5b0f58c](5b0f58c)), closes [postlund/pyatv#2282](postlund/pyatv#2282)
Hi @postlund ,
for the use-case I am currently working on, I use Airplay MAC-Adresses as an identifier maxileith/homebridge-appletv-enhanced#20. Therefore, I always need to get the MAC-Address as an identifier from
atvscript. However, currently the returned identifier fromatvscript scanis not always the MAC-Address. Therefore, I would suggest to add an attributeall_identifieresto the output json. By not touchingidentifierof the output json, backward compatability is given.I'd love to hear your thoughts on that.