Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add flag $forceMagento during generate packingslip #374

Closed
yaroslav-qlicks opened this issue Dec 22, 2023 · 2 comments
Closed

Comments

@yaroslav-qlicks
Copy link

As a admin user I'd like to generate packingslip magento even xtento or fooman modules enabled and compatibility working

I suggest to add extra flag to method signature with default value to keep back compatibility

\TIG\PostNL\Service\Shipment\Packingslip\GetPackingslip::get($shipmentId, $withLabels = true, $confirm = true, $forceMagento = false)

In this case in my own module I can set $forceMagento = true and generate magento pdf even when xtento or fooman present
because now there are no option to control this

@JorisPostNL
Copy link

Hello @yaroslav-qlicks, thank you for bringing this to our attention. We have developed a fix for this issue and will release this as soon as possible.

Kind regards
Joris
PostNL Support

@JorisPostNL
Copy link

Hi @yaroslav-qlicks, this change has now been deployed

Kind regards
Joris
PostNL Support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants