Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"not same as password" is not localized #378

Closed
krystofbe opened this issue Jan 10, 2020 · 2 comments
Closed

"not same as password" is not localized #378

krystofbe opened this issue Jan 10, 2020 · 2 comments

Comments

@krystofbe
Copy link

Hi,
thanks for this awesome lib. Do i see this correctly, that the passwords do not match message cannot be localized?
https://github.com/danschultzer/pow/blob/b1d4904492ea85287ec0845a1d9bb4635df17989/lib/pow/ecto/schema/changeset.ex#L215
@danschultzer danschultzer mentioned this issue Jan 10, 2020
Merged
@danschultzer
Copy link
Collaborator

How do you currently translate ecto errors?

Usually you would use the MyAppWeb.ErrorHelpers for translations. Also note that `v1.0.17 (#380 #379) will change that message to "does not match confirmation" so it matches the default in Ecto for confirmation validation.

@krystofbe
Copy link
Author

Yes, sorry misunderstandig, i thought there was some way to add error translations automatically like with mix gettext.extract --merge

I just added a translation for "not same as password" to errors.po

@danschultzer danschultzer mentioned this issue Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danschultzer @krystofbe