Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM / dependencies / project dependencies poms #539

Open
jonenst opened this issue Jul 26, 2023 · 0 comments
Open

BOM / dependencies / project dependencies poms #539

jonenst opened this issue Jul 26, 2023 · 0 comments

Comments

@jonenst
Copy link
Contributor

jonenst commented Jul 26, 2023

Describe the current behavior

if I override the version of powsybl-diagram from a powsybl-dependencies:

    <dependencyManagement>
        <dependencies>
            <!-- com.powsybl:powsybl-dependencies:2023.2.0 imports com.powsybl:powsybl-diagram:3.3.0, override to 4.0.0-SNAPSHOT before -->
            <dependency>
                <groupId>com.powsybl</groupId>
                <artifactId>powsybl-diagram</artifactId>
                <version>4.0.0-SNAPSHOT</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
            <dependency>
                <groupId>com.powsybl</groupId>
                <artifactId>powsybl-dependencies</artifactId>
                <version>2023.2.0</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

then iidm-impl gets scope test and programs crash at runtime:
com.powsybl.commons.PowsyblException: No NetworkFactoryService providers found

the com.powsybl:powsybl-diagram pom is supposed to be an easily importable "dependencies" pom by users (like https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.1.2/spring-boot-dependencies-3.1.2.pom ) it shouldn't change the scopes of artifacts ? This has to do with separating poms for

  • our own artifacts (BOMs)
  • our runtime dependencies ("dependencies")
  • the project build and test system (???)

Describe the expected behavior

import it and it doesn't break your app

Describe the motivation

simplicity. You can also workaround by restoring the scopes you want

Extra Information

it's always hard to do these things correctly with maven :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant