Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteMeasurement id attribute has to be optional #450

Closed
gaouizer opened this issue Jul 4, 2024 · 0 comments · Fixed by #452
Closed

DiscreteMeasurement id attribute has to be optional #450

gaouizer opened this issue Jul 4, 2024 · 0 comments · Fixed by #452
Labels
bug Something isn't working

Comments

@gaouizer
Copy link
Contributor

gaouizer commented Jul 4, 2024

Describe the current behavior

DiscreteMeasurement is expected to have an id attribute whereas it is an optional attribute for the discrete_measurement (dm) extension. Thus, when trying to open an iidm file where there are dms without ids with powsybl::iidm::Network::readXml an XmlStreamException is thrown (Attribute id does not exists").

Describe the expected behavior

powsybl::iidm::Network::readXml should be able to read iidm files where there is no id attribute in dms

Describe the steps

No response

Environment

No response

Relevant Log Output

No response

Extra Information

There are several places in the corde (e.g in powsybl::iidm::extensions::iidm::DiscreteMeasurements or in powsybl::iidm::extensions::iidm::DiscreteMeasurementAdder classes) where the logic is based on the existence of this attribute, fully solving that bug would require a bit more that solving the readXml wrong behaviour.

@gaouizer gaouizer added the bug Something isn't working label Jul 4, 2024
@gaouizer gaouizer changed the title DiscreteMeasurement id attribute has to be be optional DiscreteMeasurement id attribute has to be optional Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant