Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zoom in NAD #134

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix zoom in NAD #134

merged 3 commits into from
Dec 12, 2024

Conversation

jamal-khey
Copy link
Contributor

@jamal-khey jamal-khey commented Dec 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
When users zoom in and attempt to move the SLD, they encounter a limitation where movement in one direction becomes restricted after a certain zoom level. This issue affects the usability of the SLD, making it difficult for users to navigate the interface effectively.

What kind of change does this PR introduce?
remove the constraint on Zoompan

What is the new behavior (if this is a feature change)?
the movement is not constrained anymore

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:
Steps to Reproduce the Bug:

  1. Zoom in on a voltage level.
    2.Attempt to move the labels or the voltage level itself.
    3.Move towards the bottom.
    4.At some point, observe that movement is restricted towards the bottom of the NAD.

Signed-off-by: jamal-khey <myjamal89@gmail.com>
@jamal-khey jamal-khey self-assigned this Dec 9, 2024
Copy link
Contributor

@EstherDarkish EstherDarkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK Test OK

@jamal-khey jamal-khey changed the title fix zoom in sld fix zoom in NAD Dec 11, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Contributor

@EstherDarkish EstherDarkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working with only the removal of margins.

@flo-dup flo-dup merged commit 4a02a61 into main Dec 12, 2024
6 checks passed
@flo-dup flo-dup deleted the jamal-khey/fix-sld-zoom branch December 12, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants