Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use powsybl-core method hasImpactOnNetwork #1129

Open
annetill opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1131
Open

Use powsybl-core method hasImpactOnNetwork #1129

annetill opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1131
Assignees
Labels
feature New feature or request powsybl-core-feature

Comments

@annetill
Copy link
Member

Describe the current behavior

The PR powsybl/powsybl-core#3127 introduces a new method hasImpactOnNetwork which returns different status. The possible status are the values of enum NetworkModificationImpact:

  • CANNOT_BE_APPLIED: meaning that something wrong happens and the remedial action is not well described.
  • NO_IMPACT_ON_NETWORK: meaning that the remedial action is well described but it does not change anything on the network.
  • HAS_IMPACT_ON_NETWORK: what we expect in general.

Powsybl-open-rao does not use this method for the moment.

Describe the expected behavior

In powsybl-open-rao, methods canBeApplied and hasImpactOnNetwork should be replaced by this new method from core. Be careful because, in theory, this method has to be called just once. Plus, report if functionally some checks are wrong or incomplete.

Describe the motivation

No response

Extra Information

No response

@annetill annetill added the feature New feature or request label Sep 10, 2024
@pjeanmarie pjeanmarie linked a pull request Sep 11, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request powsybl-core-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants