CNE export no longer uses network #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
bqth29
added
PR: waiting-for-review
phiedw
reviewed
Oct 8, 2024
| Branch<?> branch = sweCneHelper.getNetwork().getBranch(networkElementId); | ||
| Branch<?> branch = cracCreationContext.getNetworkBranches().get(networkElementId); |
There was a problem hiding this comment.
we lose the aliases by doing it like this so we'll have to make sure it all works correctly still
There was a problem hiding this comment.
all tests, including business tests, passed
phiedw
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
To prepare the common RaoResult exporter using
RaoResult.writeand as presented in #1136, the CNE exporters no longer require the network as an input and the relevant information was set in the CRAC Creation Context instead.What is the current behavior?
Need of network to export RaoResult as CNE.
What is the new behavior (if this is a feature change)?
No longer need of network to export RaoResult as CNE.
exportCnemethod no longer requires theNetwork networkparameter.