Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

200 iterations maximum for ACOPF solving #60

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Mar 20, 2024

…ximum.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

The number of iterations of the non-linear solver used to solve the ACOPF problem is limited to 200 iterations.

What is the current behavior?

The number of iterations is limited to 1000 iterations, and a relaxation is applied at 600 iterations.

What is the new behavior (if this is a feature change)?
No relaxation. 200 iterations maximum.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…ximum.

Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy p-arvy requested review from Hadrien-Godard and klorel March 20, 2024 17:26
@p-arvy p-arvy self-assigned this Mar 20, 2024
@p-arvy p-arvy added the AMPL label Mar 20, 2024
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@klorel klorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@So-Fras So-Fras merged commit 2f21380 into main Mar 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants