Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py improvements #141

Merged
merged 9 commits into from
Apr 4, 2019
Merged

setup.py improvements #141

merged 9 commits into from
Apr 4, 2019

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Apr 2, 2019

Mostly the same thing as ppb/pursuedpybear#223 and ppb/pursuedpybear#224 :

  • Rename *-requirements.txt to requirements-*.txt to follow PPB's convention.
  • Extract runtime dependencies to requirements.txt.
  • Move all metadata from setup.py to setup.cfg.
  • Declare test dependencies in setup.py, integrate with pytest.
  • Use pyproject.toml to explicitly declare that we are using setuptools.

@nbraud
Copy link
Collaborator Author

nbraud commented Apr 2, 2019

I ran into a Travis issue, which I fixed in the latest last 2 commits here.

I'd honestly prefer to remove that commit and do away with Travis (by merging #127):
It's been almost 2 weeks and 13 pull requests since we set up Cirrus, and while the situation was different earlier (because Cirrus was newer and we didn't need to touch Travis for it to keep working), I'm not keen on maintaining 2 parallel CIs.

Update: Travis was dropped, Travis-related changes were dropped, see below.

@nbraud
Copy link
Collaborator Author

nbraud commented Apr 3, 2019

OK, this is ready for review and merge; I removed the Travis fixes that would have conflicted with #127

@nbraud
Copy link
Collaborator Author

nbraud commented Apr 4, 2019

PS: I chose not to make setup.py test run the linters for two reasons:

  1. A new version of the linter may add new warnings, but that's no reason to fail setup.py test && setup.py install, especially since most Linux distros use something equivalent when packaging Python things.
  2. It would make the linters a test dependency (hence, a build dependency in contexts where packages are tested at build time).

@AstraLuma
Copy link
Member

lgtm
bors r+

bors bot added a commit that referenced this pull request Apr 4, 2019
141: setup.py improvements r=astronouth7303 a=nbraud

Mostly the same thing as ppb/pursuedpybear#223 and ppb/pursuedpybear#224 :

- [x] Rename `*-requirements.txt` to `requirements-*.txt` to follow PPB's convention.
- [x] Extract runtime dependencies to `requirements.txt`.
- [x] Move all metadata from `setup.py` to `setup.cfg`.
- [x] Declare test dependencies in `setup.py`, integrate with `pytest`.
- [x] Use `pyproject.toml` to explicitly declare that we are using `setuptools`.

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Apr 4, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors bors bot merged commit 01da232 into ppb:master Apr 4, 2019
@nbraud nbraud deleted the setup.py branch April 6, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants