setup.py: Move all configuration to setup.cfg #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pytest's documented best practices: https://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner
Done on the basis of what's tested in CI.
This tells packaging tools, such as pip, that we use setuptools.
nbraud
force-pushed
the
setup.py/setup.cfg
branch
from
80d72c1 to
09998e9
Compare
pathunstrom
approved these changes
Apr 1, 2019
|
You are welcome :) |
5 tasks
bors bot
added a commit
to ppb/ppb-vector
that referenced
this pull request
Apr 4, 2019
141: setup.py improvements r=astronouth7303 a=nbraud Mostly the same thing as ppb/pursuedpybear#223 and ppb/pursuedpybear#224 : - [x] Rename `*-requirements.txt` to `requirements-*.txt` to follow PPB's convention. - [x] Extract runtime dependencies to `requirements.txt`. - [x] Move all metadata from `setup.py` to `setup.cfg`. - [x] Declare test dependencies in `setup.py`, integrate with `pytest`. - [x] Use `pyproject.toml` to explicitly declare that we are using `setuptools`. Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #223
setup.pyconfiguration and metadata tosetup.cfg, except for dependencies.pyproject.toml) defining which build system is used.setup.pyexecutable.