Actually distribute ppb.debug #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbraud
reviewed
Nov 12, 2022
| @@ -31,6 +31,7 @@ packages = | |||
| ppb | |||
| ppb.systems | |||
| ppb.features | |||
| ppb.debug | |||
There was a problem hiding this comment.
Is there a reason we shouldn't use setuptools' autodiscovery, with packages = find:, to prevent similar issues in the future?
There was a problem hiding this comment.
Pretty much only if we were doing the "tests directory in the package" thing, but we're not so this is probably an okay solution.
Can we set up a test run as part of the release process that installs the package from outside the source (I'm okay with "from cirrus's artifacts") and run tests against the installed version?
Between the automating the package list and running tests against the wheel I think we prevent any more bad from happening.
pathunstrom
added
the
3.2-targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.