Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDL #682

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix SDL #682

merged 2 commits into from
Dec 15, 2023

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented Dec 15, 2023 •
edited
Loading

Correct how we detect errors in SDL.

Closes #674
Closes #675

Viztests run.

@AstraLuma
Fix SDL error handling
04f5aee 
SDL error strings are only meaningful if SDL indicates an error
@AstraLuma
Use pysdl2-dll on Linux
932a772
@AstraLuma AstraLuma requested a review from a team as a code owner December 15, 2023 03:24
pathunstrom
pathunstrom approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass. I'll run this on my laptop in a bit to make sure the windows specific stuff isn't broken before we release.

@pathunstrom pathunstrom merged commit f8a5530 into ppb:canon Dec 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on exit "Error calling SDL_DestroyWindow: Window data not set" SDLmixererror when invoking ppb.run()
2 participants
@AstraLuma @pathunstrom