Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please modify the build script a/apicurio-registry/apicurio-registry_rhel8.sh #832

Open
afsanjar opened this issue Apr 19, 2021 · 7 comments
Assignees

Comments

@afsanjar
Copy link
Contributor

  1. Has the embedded patch in the build script pushed upstream?
  2. Is the patch dependent on a specific grpc-java version? if yes, please modify the "git clone.."
  3. Isolate the path in a separate file
  4. Include a grpc-java build Dockerfile (preferably base on a rh_ubi image)
    Use a/apicurio-registry/apicurio-registry_rhel8.sh as a reference.
@seth-priya
Copy link
Contributor

@shirodkara please address / respond

@seth-priya seth-priya self-assigned this Apr 19, 2021
@shirodkara
Copy link
Contributor

@afsanjar @seth-priya

1. Has the embedded patch in the build script pushed upstream?

No this hasn't been pushed upstream

2. Is the patch dependent on a specific grpc-java version? if yes, please modify the "git clone.."

this isn't for a specific version , but yes using a version is a better, will add the version to the "git clone.."

The change done was because on RHEL8 there is no libstdc++-static available (more info here : https://access.redhat.com/articles/rhel8-abi-compatibility in the section "Static Linking with the C/C++ Runtime")

@gerrith3
Copy link
Contributor

@shirodkara can you clarify why this patch wasn't pushed upstream? It seems like it should be?

@shirodkara
Copy link
Contributor

@gerrith3

Based on grpc/grpc-java#7757 it looked like they needed static linking for protobuf for most platforms.

Nevertheless , I have asked them whether we can upstream this , if they confirm , I'll raise a PR for this.

@afsanjar
Copy link
Contributor Author

@shirodkara could you add a condition check in your patch similar to:
if (System.getProperty('os.arch').contains('ppc64')){
linker.args "-Wl,-Bstatic", "-lprotoc", "-lprotobuf", "-static-libgcc",
"-Wl,-Bdynamic", "-lpthread", "-s"
} else {
linker.args "-Wl,-Bstatic", "-lprotoc", "-lprotobuf", "-static-libgcc",
"-static-libstdc++",
"-Wl,-Bdynamic", "-lpthread", "-s"
}

@gerrith3
Copy link
Contributor

@shirodkara Any progress on this one? Seems like @afsanjar 's solution is simple enough?

@seth-priya
Copy link
Contributor

The changes mentioned above were upstreamed to grpc-java as part of grpc/grpc-java@a6d78c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants