-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please modify the build script a/apicurio-registry/apicurio-registry_rhel8.sh #832
Comments
@shirodkara please address / respond |
No this hasn't been pushed upstream
this isn't for a specific version , but yes using a version is a better, will add the version to the "git clone.." The change done was because on RHEL8 there is no libstdc++-static available (more info here : https://access.redhat.com/articles/rhel8-abi-compatibility in the section "Static Linking with the C/C++ Runtime") |
@shirodkara can you clarify why this patch wasn't pushed upstream? It seems like it should be? |
Based on grpc/grpc-java#7757 it looked like they needed static linking for protobuf for most platforms. Nevertheless , I have asked them whether we can upstream this , if they confirm , I'll raise a PR for this. |
@shirodkara could you add a condition check in your patch similar to: |
@shirodkara Any progress on this one? Seems like @afsanjar 's solution is simple enough? |
The changes mentioned above were upstreamed to grpc-java as part of grpc/grpc-java@a6d78c5 |
Use a/apicurio-registry/apicurio-registry_rhel8.sh as a reference.
The text was updated successfully, but these errors were encountered: