Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added base class for MODNet models #49

Closed
wants to merge 5 commits into from
Closed

Added base class for MODNet models #49

wants to merge 5 commits into from

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Apr 15, 2021

Closes #47, blocked by #48.

@ml-evs ml-evs force-pushed the ml-evs/oopgrades branch 2 times, most recently from a9f3ee6 to 14f953b Compare April 15, 2021 17:27
ppdebreuck
ppdebreuck approved these changes Apr 19, 2021
View reviewed changes
Copy link
Owner

@ppdebreuck ppdebreuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, as you suggested, I think taking fit_preset out of the models would be a next thing to do. For now, I would keep it like this, to not break the benchmarks.

@ml-evs ml-evs force-pushed the ml-evs/oopgrades branch 2 times, most recently from ebc9f5f to dd573b4 Compare April 28, 2021 15:31
@ml-evs ml-evs force-pushed the ml-evs/oopgrades branch from dd573b4 to 8523396 Compare April 28, 2021 16:07
@ml-evs ml-evs marked this pull request as ready for review April 28, 2021 16:07
@ml-evs ml-evs force-pushed the ml-evs/oopgrades branch from e128b79 to ee73681 Compare April 28, 2021 16:28
@ppdebreuck ppdebreuck added this to the v0.1.11 milestone Jun 14, 2021
@ppdebreuck ppdebreuck closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppdebreuck ppdebreuck ppdebreuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.11
Development

Successfully merging this pull request may close these issues.

Make an abstract MODNetModel
2 participants
@ml-evs @ppdebreuck