Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward compatibility warning #155

Merged
merged 5 commits into from
Jul 17, 2023
Merged

backward compatibility warning #155

merged 5 commits into from
Jul 17, 2023

Conversation

ppdebreuck
Copy link
Owner

@ppdebreuck ppdebreuck commented Jul 11, 2023

Due to the new architecture default, old architectures are uncompatible. How do we proceed ...

We keep compatibility with older models via DeprectaedMODNetModel.

This is temporary, in order to test stability during v0.4, and moreover gives a transition period.

Support will be removed from v1.0 onward.

Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check this bit

modnet/models/vanilla.py Outdated Show resolved Hide resolved
@ml-evs
Copy link
Collaborator

ml-evs commented Jul 14, 2023

I will set up some tests for this in a future PR

@ppdebreuck ppdebreuck marked this pull request as ready for review July 14, 2023 12:25
@ppdebreuck ppdebreuck merged commit 85d73fc into master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants