Add blit support and fix documentation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 52.07% 52.15% +0.07%
==========================================
Files 4 4
Lines 603 604 +1
==========================================
+ Hits 314 315 +1
Misses 289 289
Continue to review full report at Codecov.
|
ppinard
reviewed
Jul 7, 2019
| * ``SI_LENGTH_RECIPROCAL``: scale bar showing 1/m, 1/cm, etc. | ||
| * ``PIXEL_LENGTH``: scale bar showing px, kpx, Mpx, etc. | ||
| * a ``matplotlib_scalebar.dimension._Dimension`` object | ||
| * ``si-length``: scale bar showing km, m, cm, etc. |
There was a problem hiding this comment.
I agree this was confusing. SI_LENGTH actually refers to a module variable, which could have been imported along the ScaleBar class, but you are write I am sure most people uses the string.
|
Thanks for the review, your comments should have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking at using
matplotlib-scalebarinhyperspyas a replacement of the current implementation of the scalebar and a few tweaks are needed to make it work.Using this scalebar is much simpler and nicer than the current implementation of the scalebar in hyperspy. It also fixed a few bugs.