-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file exclusions #125
Comments
hi @naseemkullah 👋🏽 |
hi @ppremk , Thanks so much for the quick response and taking a look 🙂 I work with @naseemkullah and we raised this issue today. The use case we have is:
This is a text file that Xcode maintains for all iOS projects. It contains all the compiler information (header search paths, dependencies, list of source file dependencies, compiler flags and configurations, and device metadata) and frequently changes when an iOS developer makes changes to the iOS project (anything from modifying compiler flags, adding third-party dependencies, and even just creating a new We need to frequently go through the process of checking this file in and resolving merge conflicts (sometimes manually). If we check this into LFS, we lose the ability to do so. This means engineers will frequently be merging broken iOS commits, so it's important we track this file using version control. This file is a one-off exception to our rule about large file sizes. |
@brenmcnamara thank you for the explanation, it is clear, we could add an input to collect a list of exception of files or its extension as suggested by @naseemkullah .. I am thinking along the line of: excludefile: # file name or extension
description: 'file to be excluded from the check'
required: false
default: '.pbxproj' would that work for you folks? 🙂 |
Looks good to me! @naseemkullah ? |
sounds great! 🙏 one thing is I think the input should be a list of glob patterns to match files for maximum flexibility, if passing in extension/filename directly we might hit some edge cases, such as a very large dotfile |
Hello @ppremk, would you be on board with adding an option to exclude certain files/file extensions from the large file check?
e.g. only want to warn on miniified
js
or largejson
files, but not xcodeproject.pbxproj
filesThe text was updated successfully, but these errors were encountered: