Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs containing blobs in history pass the action #143

Open
FloThinksPi opened this issue Aug 30, 2022 · 0 comments
Open

PRs containing blobs in history pass the action #143

FloThinksPi opened this issue Aug 30, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@FloThinksPi
Copy link

Describe the bug
Given your HEAD commit in a PR/Branch does not have a blob, the tests succeeds even when in a commit in the PR introduces a Blob.

Is there a way to detect this in an action ?

To Reproduce
Steps to reproduce the behavior:

  1. Make a branch/PR, have the action validate the PR
  2. Make a commit with a blob(tests fail)
  3. Make a second commit that converts this blob to a LFS reference(tests succede)
  4. Merge that PR (strategy merge/rebase)
  5. Now you have a blob in main branch (not in the HEAD but in the history so it blows up the repo size)

Expected behavior
Test fails when in the history of the PR a blob is found

Actual behaviour
Tests succedee as long as the HEAD commit of the branch has no blobs in it.

@ppremk ppremk added the bug Something isn't working label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants