Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action failed when submodule changed #144

Closed
jim3ma opened this issue Sep 2, 2022 · 2 comments · Fixed by #162
Closed

Action failed when submodule changed #144

jim3ma opened this issue Sep 2, 2022 · 2 comments · Fixed by #162

Comments

@jim3ma
Copy link

jim3ma commented Sep 2, 2022

Describe the bug

When the PR contains a changed submodule, the action will failed with "Not found" error message.
This error message is come from this code

To Reproduce

Steps to reproduce the behavior:

  1. Update any submodule

Expected behavior

submodule should be ignore

Screenshots

sample PR

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@jim3ma jim3ma changed the title Action failed when changed submodule version Action failed when submodule changed Sep 2, 2022
@spangaer
Copy link

spangaer commented May 5, 2023

FYI, easy to work around by defining them as exclusionPatterns

@dzmitry-lahoda
Copy link

at least can improve error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants