Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS cursor is invisible while dragging #1679

Closed
ekrctb opened this issue Jul 3, 2018 · 10 comments
Closed

OS cursor is invisible while dragging #1679

ekrctb opened this issue Jul 3, 2018 · 10 comments

Comments

@ekrctb
Copy link
Collaborator

ekrctb commented Jul 3, 2018

Press any mouse button on the game window and move mouse to outside of the game window.
Expected: OS cursor is visible.
Actual: OS cursor is invisible while pressing mouse button.
Note: Only tested on Windows. Both raw/non-raw input are affected. Confine cursor option is set to off/only full screen (obviously to move outside of the game window).

@peppy
Copy link
Member

peppy commented Jul 3, 2018

I actually think I intentionally did it this way. Open for discussion on what is the expected behaviour.

@peppy peppy added this to the Candidate Issues milestone Jul 3, 2018
@LastExceed
Copy link
Contributor

Confirmed on Linux (gnome)

On the one hand hiding the OS cursor in this case clarifies that although the window was left, the user is still interacting with it and not the desktop (or another window in the background), but on the other hand it is difficult to understand whats going on if this happens accidently as finding the way back to the window is difficult without releasing the mouse button, which could potentially mean an unwanted interaction.

I'd vote for showing the OS cursor.

@Kashouryo
Copy link

If the user is using a tablet, draging on the song list sometime will drag the cursor out of the window. It feels really weird when the cursor is out of the window and still draging with system cursor.

So I vote for not showing the system cursor.(at least not when the user is dragging a list)

@Morilli
Copy link

Morilli commented Aug 13, 2018

I personally feel like the OS cursor being shown feels pretty natural to me.

@peppy
Copy link
Member

peppy commented Sep 6, 2018

I still stand by our implementation (which is opposite to this). Unfortunately it doesn't work on macOS currently.

@smoogipoo smoogipoo modified the milestones: Candidate Issues, Backlog Jan 7, 2019
@peppy peppy removed this from the Backlog milestone Mar 17, 2020
@Joehuu
Copy link
Member

Joehuu commented Nov 28, 2020

Seems to be resolved in SDL. Looking at the discussion though, I would also want show the cursor (partly because stable does that).

@Joehuu
Copy link
Member

Joehuu commented Dec 1, 2020

Above comment was on Windows 10.

Seems to still happen on Linux (Ubuntu 20.04 to be exact).

@Susko3
Copy link
Member

Susko3 commented May 8, 2022

With #5163, the cursor is automatically captured, and is invisible (only if CursorState is Hidden).
This does seem a bit strange, as the cursor will "randomly" appear outside the window when left click is released.

To note, the cursor must be hidden for relative mode to work, so showing the cursor when Sensitivity != 1 will not feel right.

@peppy
Copy link
Member

peppy commented May 9, 2022

As I said in a much earlier post, I do think this behaviour is fine. If the game captures a drag it should keep the cursor invisible until the drag ends.

Shall we close this for now?

@Susko3
Copy link
Member

Susko3 commented May 9, 2022

Fine to close, as this issue is discussing what behaviour we want, and going forward the cursor will have to be hidden.

Relative mode enabled doesn't hide the cursor, but this will get fixed with #4055. No need to have two issues tracking the same thing.

@Susko3 Susko3 closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants