New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beatmap statistics are not updated on editor save #17676

Closed

peppy opened this issue Apr 6, 2022 · 1 comment

Labels

area:beatmap-parsing priority:0

Member

peppy commented Apr 6, 2022

The following needs to be moved out of the imported and into a place it can be run on save:

osu/osu.Game/Stores/BeatmapImporter.cs

Lines 298 to 301 in 0fcb3bd

    
           // TODO: this should be done in a better place once we actually need to dynamically update it. 
        
           beatmap.StarRating = rulesetInstance.CreateDifficultyCalculator(new DummyConversionBeatmap(decoded)).Calculate().StarRating; 
        
           beatmap.Length = calculateLength(decoded); 
        
           beatmap.BPM = 60000 / decoded.GetMostCommonBeatLength();

peppy added priority:0 area:beatmap-parsing labels

bdach mentioned this issue

Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo #17678

Merged

peppy mentioned this issue

Implement robust beatmap invalidation / update flow #18665

Closed

4 tasks

Member Author

peppy commented Jul 2, 2022

Resolved via #18835

peppy closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment