Inconsistent sliderfollowcircle size between stable and lazer

[Szago]

Type

Cosmetic

Bug description

Lazers sliderfollowcircle is way bigger than on stable, same behavior on every skin.

Screenshots or videos

Stable:

Lazer:

Version

2022.409.0-lazer

Logs

runtime.log
updater.log
database.log
network.log
performance.log
performance-audio.log
performance-draw.log
performance-input.log
performance-update.log

[bdach]

I believe the follow circle is larger because stable actually kind of lies to the user by showing a smaller follow circle than the size of the tracking area. This was intentionally changed in lazer so that the follow circle always matches the tracking area 1:1.

Related: #14832 (comment), #7714.

I think this is a "closing as intended" situation?

[Szago]

So is it going to stay in the "inconsistent" zone forever? There are other visual changes that are revertible using classic mod, why not this one?

[bdach]

Because the behaviour and sizing of the follow circle is confusing even for legacy logic standards. See this review comment.

I'm not necessarily calling the shots on this by any stretch but the fact that pull has been unmerged for so long tells you that this is not exactly an uncontroversial change.

[CenTdemeern1]

Suggestion: the classic skin could scale the follow circle back down.
Might be a bad idea though

[bdach]

@CenTdemeern1 did you miss the part where i linked #7714 which was explicitly a revert of such a change (#7704)?

[Szago]

I have no idea how code underneath that works but just to make sure.. can you still manipulate the size of the follow circle by making the skin element smaller or will it be stretched to match the constant size set in lazer?

[CenTdemeern1]

@CenTdemeern1 did you miss the part where i linked #7714 which was explicitly a revert of such a change (#7704)?

Ooh so that's what that was