Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User skin sprites display opacity different under Metal #30399

Closed
peppy opened this issue Oct 23, 2024 Discussed in #30148 · 4 comments
Closed

User skin sprites display opacity different under Metal #30399

peppy opened this issue Oct 23, 2024 Discussed in #30148 · 4 comments
Labels
osu!framework issue Can't resolve this without changes to osu!framework. priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@peppy
Copy link
Member

peppy commented Oct 23, 2024

This needs investigation. We're potentially still doing premultiplied alpha wrong.

Discussed in #30148

Originally posted by cdwcgt October 9, 2024
on iOS(iPadOS) and MacOS:

on iOS(iPadOS) and MacOS on Windows
on iOS(iPadOS) and MacOS on Windows

The fruit is noticeably darker

on iOS(iPadOS) and MacOS on Windows
on iOS(iPadOS) and MacOS on Windows

The area around the cursor(and tail) is noticeably darker

std skin: https://files.catbox.moe/01isxd.osk
ctb skin: https://files.catbox.moe/f7172e or https://www.swisstransfer.com/d/d800340d-c3b0-4244-92ca-56a4a3932087

@peppy peppy added osu!framework issue Can't resolve this without changes to osu!framework. priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Oct 23, 2024
@peppy peppy changed the title The same skin displays differently on Apple and non-Apple devices User skin sprites display opacity different under Metal Oct 23, 2024
@ppy ppy deleted a comment Oct 28, 2024
@smoogipoo
Copy link
Contributor

smoogipoo commented Nov 15, 2024

The issue says iOS and macOS, but I can't replicate on macOS. And I'm very well aware that this is an issue on iOS, I've both been told IRL many times how shocking the cursor trail looks and I think there's an o!f issue for that already.

But, for macOS, can anyone confirm this to be broken there?

@peppy
Copy link
Member Author

peppy commented Nov 15, 2024

Definitely going to be iOS/iPadOS only. Skins look fine here on macOS.

@Joehuu
Copy link
Member

Joehuu commented Nov 15, 2024

Same here.

The framework issue is ppy/osu-framework#2194. Not sure what the stance is now on having the same issue in framework and here for visibility. I would close in this case because it's only on iOS and is only visual.

@smoogipoo
Copy link
Contributor

Let's close this one and keep tracking there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
osu!framework issue Can't resolve this without changes to osu!framework. priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

3 participants