Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menu cursor on touch devices #7437

Closed
mcendu opened this issue Jan 4, 2020 · 5 comments · Fixed by #10074
Closed

Hide menu cursor on touch devices #7437

mcendu opened this issue Jan 4, 2020 · 5 comments · Fixed by #10074

Comments

@mcendu
Copy link
Contributor

mcendu commented Jan 4, 2020

Describe the new feature: Cursor showing up is not expected and looks bad on touch devices, and should be hidden. Cursor in std mode should not be hidden.

Proposal designs of the feature: When touch input is used, an invisible drawable would be drawn in place of the cursor.

@bdach
Copy link
Collaborator

bdach commented Jan 4, 2020

Related to ppy/osu-framework#1514 (probably going to need to expose something framework-side to indicate a touch device is being used).

@ThatStella7922
Copy link

ThatStella7922 commented Jan 8, 2020

Cursor showing up is not expected and looks bad on touch devices, and should be hidden.

I think it looks great and with the cursor rotation it makes the menu cursor feel fun on mobile/touch screens. Also since this is osu!, I feel like not having a menu cursor would be strange considering the type of UI that is being used especially in places like the settings where everything isn’t mobile oriented.
Maybe hiding menu cursor on touch devices could be added as a toggle somewhere near the bottom of the settings or in the section where cursor settings currently are.

@peppy
Copy link
Member

peppy commented Jan 8, 2020

a toggle is fine, but the default would be hidden.

@Squiddu
Copy link
Contributor

Squiddu commented Jan 11, 2020

@ThatsNiceGuy Keep in mind that on mobile the cursor may cause unneeded lag.
(This comment was not needed, just wanted to point it out.)

@mcendu
Copy link
Contributor Author

mcendu commented Jan 11, 2020

Edited description for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants