Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #30337

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Update dependencies #30337

merged 3 commits into from
Oct 18, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 18, 2024

I'm not 100% on the exception changes, but seems to be required.

The packages excluded from this bump all have issues that are high(er) effort or blocked.

@bdach bdach self-requested a review October 18, 2024 07:40
@bdach bdach added the dependencies Pull requests that update a dependency file label Oct 18, 2024
@bdach
Copy link
Collaborator

bdach commented Oct 18, 2024

Tested multiplayer and spectator full-stack, seems to work. Also tested exceptions (via sending a multi invite to a user who blocked sender), and also seems to work.

For whatever it's worth, https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0051 claims that [Serializable] is also removable, but I'm not so sure about that so I'd rather not here.

Going to wait for CI to complete before merging but source seems ok.

@bdach bdach merged commit 2ef5fa3 into ppy:master Oct 18, 2024
11 of 13 checks passed
@peppy peppy deleted the update-dependencies branch October 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants