Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid retrying initialize request on InvalidParams #1351

Closed
radeksimko opened this issue Aug 22, 2022 · 2 comments
Closed

Avoid retrying initialize request on InvalidParams #1351

radeksimko opened this issue Aug 22, 2022 · 2 comments
Labels

Comments

@radeksimko
Copy link
Contributor

As discovered in hashicorp/terraform-ls#1041 vim-lsp resends initialize request when the server responds -32602 (InvalidParams) error code.

It is highly unlikely that any server would respond successfully on any following attempt when the parameters are wrong, so I would suggest that retries are not attempted on this particular error as it can also mask the original problem (as fixed in #1350).

@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 1, 2022
@radeksimko
Copy link
Contributor Author

This is still a valid bug AFAICT

@stale stale bot closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant