Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better locations for "edit this page" #9

Open
pradyunsg opened this issue Mar 20, 2022 · 4 comments
Open

Implement better locations for "edit this page" #9

pradyunsg opened this issue Mar 20, 2022 · 4 comments
Labels
type: task Something that needs to be done that is not a bug or feature

Comments

@pradyunsg
Copy link
Owner

It is currently in the right sidebar (above "on this page") which doesn't work too well for things like landing pages of a website.

@pradyunsg pradyunsg added type: task Something that needs to be done that is not a bug or feature state: needs research More information is needed for driving this issues to a resolution labels Mar 20, 2022
@pradyunsg
Copy link
Owner Author

I think this belongs next to the article's first heading or in the article footer.

@pradyunsg
Copy link
Owner Author

Let's do both, with former being configurable via "top_of_article_links": ["view", "edit"].

@pradyunsg pradyunsg removed the state: needs research More information is needed for driving this issues to a resolution label Jul 10, 2022
@pradyunsg pradyunsg changed the title Explore better locations for "edit this page" Implement better locations for "edit this page" Jul 10, 2022
@pradyunsg
Copy link
Owner Author

The missing piece here is top_of_article_links, since I like the location of where the icons are now.

@corneliusroemer
Copy link

How is it possible to configure this? The docs only say "Todo" unfortunately: https://pradyunsg.me/lutra/customisation/edit-view-buttons/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task Something that needs to be done that is not a bug or feature
Projects
None yet
Development

No branches or pull requests

2 participants