Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customized config to skip finalizers. #400

Closed
realAaronWu opened this issue Oct 14, 2021 · 1 comment
Closed

Add customized config to skip finalizers. #400

realAaronWu opened this issue Oct 14, 2021 · 1 comment

Comments

@realAaronWu
Copy link
Contributor

Description

Zookeepercluster has mandatory finalizers in order to delete pvcs when deleting the pods. This should be fine if we always delete Zookeepercluster pods before deleting the operators. This can be done by injecting a helm pre-delete hook. But on VS7 env, they forbid calling helm hooks, and VS terminates the namespace which kills all pods/secrets/configmaps at once without ordering, so deadlock can happen if operators are killed first before the Zookeepercluster pods. Add this config flag to skip adding finalizers to Zookeepercluster to avoid this situation.

Importance

should-have

Location

reconcileFinalizers logic

Suggestions for an improvement

Add disableFinalizer config

@anishakj
Copy link
Contributor

anishakj commented Nov 2, 2021

Fixed by PR #401

@anishakj anishakj closed this as completed Nov 2, 2021
@anishakj anishakj added this to the Release 0.2.14 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants