Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+ #428

Closed
cbuto opened this issue Jan 24, 2022 · 6 comments · Fixed by #523
Closed

policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+ #428

cbuto opened this issue Jan 24, 2022 · 6 comments · Fixed by #523

Comments

@cbuto
Copy link
Contributor

cbuto commented Jan 24, 2022

Description

The PodDisruptionBudget created for zookeeper clusters needs to be updated to use policy/v1.

W0124 15:31:48.254050       1 warnings.go:67] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget

Importance

This is fairly low importance right now but should be addressed before 1.25+ (which is a ways out)

Location

https://github.com/pravega/zookeeper-operator/blob/master/pkg/controller/zookeepercluster/zookeepercluster_controller.go#L529

func MakePodDisruptionBudget(z *v1beta1.ZookeeperCluster) *policyv1beta1.PodDisruptionBudget {

Suggestions for an improvement

I'm not sure what the Kubernetes version support looks like for this project, but policy/v1 is only available in 1.21+ clusters so that's something to consider.

@cbuto
Copy link
Contributor Author

cbuto commented Jan 11, 2023

thanks @anishakj!

Is there a release cadence or do you have an idea of when the next release would be?

@cbuto
Copy link
Contributor Author

cbuto commented Jan 26, 2023

👋 friendly ping @anishakj to see if there's any info about ^

@TeddyAndrieux
Copy link

🆙 @anishakj

Since there is no release with this fix, the operator is unusable for Kubernetes 1.25+, any plan for the next release ?

@anishakj
Copy link
Contributor

@TeddyAndrieux we will do it by end of this month.

@TeddyAndrieux
Copy link

Perfect, thank you 👍

@TomBillietKlarrio
Copy link

We'd also appreciate a release since we're working to upstep to 1.25 🙏
Thanks upfront!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants