Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 222: zoo.cfg updated parameters are not picked up during rolling restarts #231

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anisha.kj anisha.kj@dell.com

Change log description

We were copying zoo.cfg file from /conf directory to /data/conf.cfg only at the start. If any configuration parameters are changed after installation, it was not taking into effect.

Purpose of the change

Fixes #222

What the code does

Modified the start up script such a way that /conf/zoo.cfg contents are copied to /data/conf.cfg even on restart. Will retain the dynamicconfig file in /data/conf.cfg

How to verify it

Verified by changing the config parameters and saw that they are getting updated on rolling restarts.

Signed-off-by: anisha.kj <anisha.kj@dell.com>
@codecov-commenter
Copy link

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          11       11           
  Lines        1220     1220           
=======================================
  Hits         1020     1020           
  Misses        137      137           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88ce7c...9694e1d. Read the comment docs.

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 8e8f8a3 into master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zoo.cfg updated parameters are not picked up during rolling restarts
3 participants