Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marker comments for runtime object deepcopy #261

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

jiayushe
Copy link
Contributor

@jiayushe jiayushe commented Oct 20, 2020

Change log description

Fix marker comments for runtime object deepcopy.

Purpose of the change

The marker comments for runtime object deepcopy was wrongly located. As such, the runtime object deepcopy code was not generated via operator-sdk generate k8s as expected. This change fixes the issue.

What the code does

Fix location of marker comments for runtime object deepcopy so that the deepcopy code gets generated correctly.

How to verify it

operator-sdk generate k8s should generate runtime object deepcopy code correctly.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 6cef7c5 into pravega:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants