Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 275: Made changes for configuring probes #290

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

Made the changes for configuring readiness probe and liveness probe timeout values

Purpose of the change

Fixes #275

What the code does

User will be able to specify initial delay seconds, timeout, success and failure threshold via charts

How to verify it

Verified that able to configure values for readiness and liveness probes

Signed-off-by: anishakj <anisha.kj@dell.com>
@anishakj anishakj requested review from SrishT, Prabhaker24 and Ranganaths8 and removed request for SrishT January 11, 2021 08:59
@codecov-io
Copy link

Codecov Report

Merging #290 (22a0b33) into master (ce7b41d) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   84.07%   84.41%   +0.33%     
==========================================
  Files          11       11              
  Lines        1206     1232      +26     
==========================================
+ Hits         1014     1040      +26     
  Misses        129      129              
  Partials       63       63              
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.61% <100.00%> (+0.14%) ⬆️
pkg/zk/generators.go 99.23% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7b41d...22a0b33. Read the comment docs.

Signed-off-by: anishakj <anisha.kj@dell.com>
Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to generate deepcopy.go as well and add the corresponding ut's. Deepcopy might change as we are adding new probe struct in zookeepercluster_types.go

charts/zookeeper/values.yaml Outdated Show resolved Hide resolved
charts/zookeeper/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: anishakj <anisha.kj@dell.com>
Signed-off-by: anishakj <anisha.kj@dell.com>
@anishakj
Copy link
Contributor Author

Can you try to generate deepcopy.go as well and add the corresponding ut's. Deepcopy might change as we are adding new probe struct in zookeepercluster_types.go

Added those changes

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit e393d1f into master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make LivenessProbe,ReadinessProbe initialdelayseconds,timeout configurable thru CRD
3 participants