-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 275: Made changes for configuring probes #290
Conversation
Signed-off-by: anishakj <anisha.kj@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 84.07% 84.41% +0.33%
==========================================
Files 11 11
Lines 1206 1232 +26
==========================================
+ Hits 1014 1040 +26
Misses 129 129
Partials 63 63
Continue to review full report at Codecov.
|
Signed-off-by: anishakj <anisha.kj@dell.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to generate deepcopy.go as well and add the corresponding ut's. Deepcopy might change as we are adding new probe struct in zookeepercluster_types.go
Signed-off-by: anishakj <anisha.kj@dell.com>
Signed-off-by: anishakj <anisha.kj@dell.com>
Added those changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: anishakj anisha.kj@dell.com
Change log description
Made the changes for configuring readiness probe and liveness probe timeout values
Purpose of the change
Fixes #275
What the code does
User will be able to specify initial delay seconds, timeout, success and failure threshold via charts
How to verify it
Verified that able to configure values for readiness and liveness probes