-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 338: CRD template refactor to accommodate different api versions #339
Issue 338: CRD template refactor to accommodate different api versions #339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 11 11
Lines 1358 1358
=======================================
Hits 1153 1153
Misses 135 135
Partials 70 70 Continue to review full report at Codecov.
|
@lspecian-olx , how you have generated crd file? Is there any tools used |
hello @anishakj, I used only helm templates, not sure if I understood the question |
Have you used any commands like |
@lspecian-olx, could you please resolve the conflict? |
4461c77
to
b203bc1
Compare
@lspecian-olx Looks like there is parse error after conflicts are resolved. Getting below error while try to install
|
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very minor comment needs to be addressed, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change log description
In order to accommodate the both api versions schemas apiextensions.k8s.io/v1 and apiextensions.k8s.io/v1beta1
Purpose of the change
Closes #338
What the code does
The code is checking .Capabilities.APIVersions.Has "apiextensions.k8s.io/v1" and adapting the template output accordingly to the support for the apiVersion
How to verify it
Chart is able to install in eks clusters that support both apiVersions apiextensions.k8s.io/v1 and apiextensions.k8s.io/v1beta1