Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove wallet birthday height from onboarding flow #221

Closed
TalDerei opened this issue Oct 24, 2024 · 0 comments · Fixed by #231
Closed

remove wallet birthday height from onboarding flow #221

TalDerei opened this issue Oct 24, 2024 · 0 comments · Fixed by #231
Labels
refactor Improving existing system with new design

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Oct 24, 2024

wallet birthday's should be abstracted as an internal implementation detail that's not exposed in the UI, in line with the philosophy that seed phrases are the sole information needed to completely recover all wallet state. This additional step introduces a new pattern for key management that add unnecessary complexity to the onboarding flow. However, new wallets will still benefit from the sync efficiency gains by skipping trial decryption during the initial onboarding process.

This will be consumed as part of a more comprehensive issue focused on reworking the onboarding flow. cc @grod220

@TalDerei TalDerei added the refactor Improving existing system with new design label Oct 24, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Oct 24, 2024
This was referenced Nov 1, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Labs web Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improving existing system with new design
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant