-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preact create does not write the proper name in the package.json file #408
Comments
Thanks. Looks like I missed a default assignment. In the meantime, use |
Thanks @lukeed. Yes, I am using that parameter. Already edited the issue :) |
I've came across this issue also, and seems like it silently fails to run |
the problem also appears in manifest.json as: |
@mutebg Correct. Just waiting on a fellow team member to scoot it in for a quick |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Package.json name property is not overriden (i.e. it maintains the placeholder
"name": "{{ name }}"
)If the current behavior is a bug, please provide the steps to reproduce.
Run the following steps:
preact create default some-name
cd some-name
yarn
The following error is thrown:
error package.json: Name contains illegal characters
If we pass a
--name
parameter, all works as expected. E.g.preact create default some-name --name some-name
.What is the expected behavior?
Either reflect the parameter requirement in the documentation or automatically map the project name.
The name property should be overwritten in the package.json file:
{ "name": "some-name" ... }
Please mention other relevant information.
The text was updated successfully, but these errors were encountered: