fix: Wildcard splat/rest param matches should return undefined instead of empty strings
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
undefined instead of empty strings
rschristian
changed the title
undefined instead of empty stringsundefined instead of empty strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst preactjs/wmr@d503514 added a test entry for
/:x*paths, unfortunately it copied the test block for optional params (/:x?) and only updated the test name -- the actual test cases were duplicates that didn't ensure what they were meant to.This PR therefore corrects that and adds proper tests, but also ensures optional params become
undefined, rather than empty strings, to match the behavior of/:x?in the case of the param not being set. I'd call this non-breaking as the previous behavior isn't correct or consistent and any falsy check will still fail all the same.